-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not skip metadata API check by default #3960
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
I've got the newly written test pass locally but it unfortunately is tripping up some other tests in the suite, will need another pass. Also as a side note in my VA -> us-east-1 setup I'm only getting 2MB/s from CopyFile and only slightly more up to 2.5MB/s from uploading to S3, this is a bit disappointing to upload the 700MB aws provider (yes we need to slim this down):
|
Disregard the above comment, had to troubleshoot and fix local home network |
I've only tested IMDS(v2) not IMDS(v1) but I have no reasons to believe that reverting to defaults wouldn't fix that as well. |
This PR explores reverting the default
aws:skipMetadataApiCheck=false
setting to enable the provider to be able to seamlessly authenticate against an IMDS(v2) endpoints in the AWS environment. It appears that doing so no longer slows down the provider startup time perceptibly. The way I tested the speed delta was by measuring local empty preview of an AWS s3 Bucket using AWS_PROFILE authentication with local <-> us-east-1 there is no perceptible difference.Fixes: #1692
An integration test is added that exercises
pulumi preview
on an EC2 instance with IMDSv2 and asserts that the provider can authenticate successfully.Background: