Fix static get function for ssm.parameter with versioned or labeled IDs #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the upstream SSM resources where moved to the AWS SDK v2 the lookup of SSM parameters with versions or labels got broken. This fixes that again.
flostadler
commented
Jun 3, 2024
| return sdkdiag.AppendErrorf(diags, "invalid configuration, cannot set type = %s and insecure_value", param.Type) | ||
| } | ||
|
|
||
| - detail, err := findParameterMetadataByName(ctx, conn, d.Id()) |
There was a problem hiding this comment.
Before moving to SDK v2 it used the name. That's why the regression was introduced
There was a problem hiding this comment.
@flostadler that's very unfortunate. I'll add to our roadmap one more time the task of covering all patches with tests. It has to be done alas.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
iwahbe
approved these changes
Jun 3, 2024
|
/release patch |
github-actions
bot
added
the
needs-release/patch
github-actions
bot
removed
the
needs-release/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the upstream SSM resources where moved to the AWS SDK v2 the lookup of
SSM parameters with versions or labels got broken. This fixes that
again.
Fixes #4011