Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upstream v5.52.0 #4025

Merged
merged 5 commits into from
Jun 6, 2024
Merged

upstream v5.52.0 #4025

merged 5 commits into from
Jun 6, 2024

Conversation

flostadler
Copy link
Contributor

  • Moving ./upstream to v5.52.0
  • Update patches

@flostadler flostadler requested review from a team and t0yv0 June 5, 2024 16:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe
Copy link
Member

iwahbe commented Jun 5, 2024

Looks like you are missing a make tfgen build_sdks

@flostadler
Copy link
Contributor Author

Looks like you are missing a make tfgen build_sdks

Yeah missed pushing that commit :(

@flostadler flostadler marked this pull request as draft June 5, 2024 21:18
@flostadler flostadler self-assigned this Jun 6, 2024
@flostadler flostadler marked this pull request as ready for review June 6, 2024 09:12
t0yv0
t0yv0 reviewed Jun 6, 2024
View reviewed changes
sdk/nodejs/kinesisanalyticsv2/application.ts
@@ -262,6 +262,10 @@ export class Application extends pulumi.CustomResource {
* The application's configuration
*/
public readonly applicationConfiguration!: pulumi.Output<outputs.kinesisanalyticsv2.ApplicationApplicationConfiguration>;
/**
* The application's mode. Valid values are `STREAMING`, `INTERACTIVE`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pity not an enum here.

@t0yv0
Copy link
Member

t0yv0 commented Jun 6, 2024

PR schema check is suspect it didn't summarize actual changes like this added property:

                "timestreaminfluxdb": {
                    "type": "string",
                    "description": "Use this to override the default service endpoint URL\n"
                },

@t0yv0 t0yv0 mentioned this pull request Jun 6, 2024
Closed
@t0yv0
Copy link
Member

t0yv0 commented Jun 6, 2024

pulumi/schema-tools#73

@t0yv0 t0yv0 self-requested a review June 6, 2024 15:02
@flostadler flostadler merged commit a5d58e9 into master Jun 6, 2024
24 checks passed
@flostadler flostadler deleted the upstream-v5.52.0 branch June 6, 2024 15:24
@flostadler flostadler mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

Assignees

@flostadler flostadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flostadler @iwahbe @t0yv0