Suppress undefined to default diffs on aws.autoscaling.Group #4510
Conversation
Fix a regression in the import experience on aws.autoscaling.Group. Specifically the conflict between undefined and default values that `pulumi import` used to detect is no longer a conflict by automatically injecting DiffSuppressFunc for the relevant properties. Fixes #4457
| t.Logf("workdir = %s", workdir) | ||
| importResult := execPulumi(t, ptest, workdir, "import", "aws:autoscaling/group:Group", "newag", autoGroupName, "--yes") | ||
|
|
||
| t.Logf("Editing the program to add the code recommended by import") |
There was a problem hiding this comment.
AFAIK we have no precedent of testing this, throwing in some automation, can generalize later if this is important. I have a suspicion that the issue generalizes to many resources in the ecosystem as TF Read() is not guaranteed to apply defaults.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
I was a little surprised but TransformOutputs hook works well. It is able to eliminate the default values from the printed imported program which is good, and it also fixes the issue. The ability to be certain about undefined vs null vs empty is much appreciated. I think it also bypasses the problem with hypothetical defaults change. |
|
I've tested refresh and import_ option manually, seem to work as well for this with these changes. |
| } | ||
| } | ||
| defaults := map[string]resource.PropertyValue{ | ||
| "forceDelete": defaultValue("force_delete"), |
There was a problem hiding this comment.
Can we detect the props that need the defaults to be fixed? This would help us generalize this and also make maintenance a bit easier (no need to play catchup with upstream).
There was a problem hiding this comment.
I think this works so well we should maybe change the bridge default behavior here in pulumi/pulumi-terraform-bridge#2436 so that's how it works by default without the custom code.
|
This PR has been shipped in release v6.53.0. |
Fix a regression in the import experience on aws.autoscaling.Group. Specifically the conflict between undefined and default values that
pulumi importused to detect is no longer a conflict by automatically injecting DiffSuppressFunc for the relevant properties.Fixes #4457