Re-generate schema to fix aws.iam.Role description #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
approved these changes
Oct 1, 2024
flostadler
approved these changes
Oct 1, 2024
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
This PR has been shipped in release v6.54.2. |
Closed
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 2, 2024
##### [`v6.54.2](https://github.com/pulumi/pulumi-aws/releases/tag/v6.54.2) ##### Does the PR have any schema changes? Looking good! No breaking changes found. No new resources/functions. #### What's Changed - Re-generate schema to fix aws.iam.Role description by [@t0yv0](https://github.com/t0yv0) in pulumi/pulumi-aws#4589 - Set explicit version for .NET core SDK requirement by [@justinvp](https://github.com/justinvp) in pulumi/pulumi-aws#4591 - Add pluralized lifecycle_policies to EFS file system data source by [@flostadler](https://github.com/flostadler) in pulumi/pulumi-aws#4590 - Update GitHub Actions workflows. by [@pulumi-bot](https://github.com/pulumi-bot) in pulumi/pulumi-aws#4592 **Full Changelog**: pulumi/pulumi-aws@v6.54.1...v6.54.2
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 2, 2024
##### [`v6.54.2](https://github.com/pulumi/pulumi-aws/releases/tag/v6.54.2) ##### Does the PR have any schema changes? Looking good! No breaking changes found. No new resources/functions. #### What's Changed - Re-generate schema to fix aws.iam.Role description by [@t0yv0](https://github.com/t0yv0) in pulumi/pulumi-aws#4589 - Set explicit version for .NET core SDK requirement by [@justinvp](https://github.com/justinvp) in pulumi/pulumi-aws#4591 - Add pluralized lifecycle_policies to EFS file system data source by [@flostadler](https://github.com/flostadler) in pulumi/pulumi-aws#4590 - Update GitHub Actions workflows. by [@pulumi-bot](https://github.com/pulumi-bot) in pulumi/pulumi-aws#4592 **Full Changelog**: pulumi/pulumi-aws@v6.54.1...v6.54.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4588
This simply a result of executing
make tfgen. There is no impact on SDKs its seems. There should be however impact on the registry.This is a little un-intuitive but schema.json does not get reused for SDK generation. Instead we have something like this:
It looks like CI is missing a check that re-generating schema.json with
make tfgenis a no-change operation, allowing this to drift and break registry. Filing an issue in ci-mgmt.pulumi/ci-mgmt#1090