Update ci-mgmt to strip debug symbols from provider binaries #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Closed
iwahbe
approved these changes
Nov 18, 2024
flostadler
added
the
needs-release/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change pulls the latest ci-mgmt changes in order to reduce the size of provider binaries. In detail, we're now setting the
-s -wlinker flags to strip debug symbols. This cuts the provider binary size by roughly 300MB, resulting in a 32% smaller provider binary.Note: I also had to change
toolVersions.nodetotoolVersions.nodejsbecause the configuration is now type checked. ThetoolVersions.nodeconfiguration option was renamed tonodejsin this PR: pulumi/ci-mgmt#1063