-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos triggered Functions #237
Conversation
sdk/nodejs/cosmosdb/zMixins.ts
Outdated
direction: "in", | ||
type: "cosmosDBTrigger", | ||
leaseCollectionPrefix: name, | ||
createLeaseCollectionIfNotExists: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be user configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to expose all properties as configurable? (there are more of them) Or take some defaults for now, which make sense in 95% of cases? (my call)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can totally not expose if we think this is reasonable. users can always request in the future. though we should likely doc why we think this is the right default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment to cover both.
Is onChange() still the recommended way of triggering functions through cosmos DB? I have encountered a problem that the lease collection is not created even though createLeaseCollectionIfNotExists is set to true. |
Part of #218