Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos triggered Functions #237

Merged
merged 11 commits into from
May 14, 2019
Merged

Cosmos triggered Functions #237

merged 11 commits into from
May 14, 2019

Conversation

mikhailshilkov
Copy link
Member

Part of #218

@mikhailshilkov mikhailshilkov changed the title Cosmos trigger Cosmos triggered Functions May 9, 2019
CyrusNajmabadi
CyrusNajmabadi reviewed May 13, 2019
View reviewed changes
sdk/nodejs/cosmosdb/zMixins.ts Outdated
direction: "in",
type: "cosmosDBTrigger",
leaseCollectionPrefix: name,
createLeaseCollectionIfNotExists: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be user configurable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to expose all properties as configurable? (there are more of them) Or take some defaults for now, which make sense in 95% of cases? (my call)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can totally not expose if we think this is reasonable. users can always request in the future. though we should likely doc why we think this is the right default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to cover both.

@lukehoban lukehoban merged commit 1ea4b27 into pulumi:master May 14, 2019
@henriktao
Copy link
Contributor

Is onChange() still the recommended way of triggering functions through cosmos DB? I have encountered a problem that the lease collection is not created even though createLeaseCollectionIfNotExists is set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikhailshilkov @henriktao @CyrusNajmabadi @lukehoban