Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip pending deployments in a queue #136

Closed
2 tasks
alexanderniebuhr opened this issue Nov 9, 2022 · 2 comments · Fixed by pulumi/pulumi-pulumiservice#162
Closed
2 tasks

skip pending deployments in a queue #136

alexanderniebuhr opened this issue Nov 9, 2022 · 2 comments · Fixed by pulumi/pulumi-pulumiservice#162
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@alexanderniebuhr
Copy link

alexanderniebuhr commented Nov 9, 2022

  • Design doc reviewed with the team
  • Project plan reviewed with @EvanBoyle

if multiple commits are pushed to an repository in an on-push scenario an deployment is triggered for every commit. The deployments run sequentially. If all the commits are on the same branch, the latest commit / deployment, will include all the changes of the commits / deployments before it.
I propose to add an configuration flag which enables skipping of pending deployments in a queue except the current running and the last one. We currently merge multiple PRs at a specific time range, and end up with 10s of deployments, restarting our services multiple times (which is uncessary). some note copied over from slack:

  • we are currently interested in the push-to-deploy scenario, however I think having it configurable for different combinations of triggers would be great
  • cancelled deployments should be still shown in the UI, GitHub Actions has an similar approach (see screenshot)

Screenshot 2022-11-09 at 06 26 32

@EvanBoyle EvanBoyle added the kind/enhancement Improvements or new features label Nov 9, 2022
@EvanBoyle
Copy link
Contributor

We could optionally make this configurable as well. There may be multi-step rollouts that depend on several updates being run in sequence. We did this recently with our MySQL 5.6 EOL upgrade.

@glena glena self-assigned this Aug 9, 2023
glena added a commit to pulumi/pulumi-pulumiservice that referenced this issue Aug 29, 2023
Adds support to the new `skipIntermediateDeployments` on
`DeploymentSettings`.

Fix pulumi/pulumi-cloud-requests#136
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 29, 2023
@glena
Copy link

glena commented Aug 29, 2023

The feature was implemented and is already available in production. The documentation can be found here https://www.pulumi.com/docs/pulumi-cloud/deployments/reference/#skip-intermediate-deployments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants