Wait for ECS services to reach steady state #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New pulumi-aws requires new pulumi because of plugin name changes
mmdriley
force-pushed
the
wait-for-update
branch
from
8ce30eb
to
da7acc8
Compare
|
Whoops, didn't mean to submit this without review. I think I just got overly excited that CI passed. |
|
Post-hoc LGTM. I was surprised that this didn't appear to increase the integration test runtime. Especially given that we serially bring up each service, I would have expected this to add on the order of 10 minutes to the test runtime. I'm also a little nervous about what the failure modes will look like here - but I suspect we just have to get some experience with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312