Add support for deserializing output values #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for deserializing output values for transforms. This is necessary as the engine will send output values to transforms, so we need to handle deserializing them before calling the transform and then properly serializing them when returning the results.
justinvp
force-pushed
the
justin/outputvalues
branch
from
58034da
to
7993cd8
Compare
justinvp
added a commit
to pulumi/docs
that referenced
this pull request
Jul 17, 2024
Depends on pulumi/pulumi-dotnet#298
Frassle
reviewed
Jul 17, 2024
| // The data from the engine will include output values, which will be deserialized | ||
| // into instances of `Output<T>`, which will track whether the value is known, | ||
| // is secret, and dependencies. We can ignore those values on outputData. | ||
| props.Add(kv.Key, outputData.Value); |
There was a problem hiding this comment.
Doesn't this still need to check the OutputData for known/secretness? Doesn't look like Deserialise is returning Output for those, just for actual output wire objects.
There was a problem hiding this comment.
I don't think so. Shouldn't everything be coming across from the engine to transforms as output values? In which case, those will already have the known/secretness/dependency tracking.
There was a problem hiding this comment.
For transforms yes, but isn't this used for other deserialisation for invokes/resources?
There was a problem hiding this comment.
Ah no ignore me, this is specific to transforms. Should be fine then.
Frassle
approved these changes
Jul 18, 2024
|
This PR has been shipped in release v3.65.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for deserializing output values and ensures they work for transforms. This is necessary as the engine will send output values to transforms, so we need to handle deserializing them before calling the transform and then properly serializing them when returning the results.
Fixes #297