Fix unknown inputs deserialization #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unknown Input will be serialized as a OutputReference without the value field in the struct. We now correctly set the value to be a computed PropertyValue in Unmarshal. The PropertyValueSerializer now checks if an OutputReference contained a computed value which means it's an unknown Input
Frassle
reviewed
Jul 24, 2024
jkerken
force-pushed
the
fix-unkown-inputs-deserialization
branch
from
3178cb4
to
f1e2ab6
Compare
Frassle
changed the title
Frassle
reviewed
Jul 24, 2024
Frassle
reviewed
Jul 24, 2024
Frassle
reviewed
Jul 24, 2024
Zaid-Ajaj
approved these changes
Jul 25, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
## v3.66.0 - 2024-08-09 ### Improvements - [sdk] Support package parameterization for Read/RegisterResource/Call/Invoke [#311](#311) ### Bug Fixes - [sdk] Fix type annotations for inputListFromT0/1 [#301](#301) - [sdk] Fix race condition in GrpcMonitor's GrpcChannel management [#304](#304) - [sdk] Fix unknown inputs deserialization [#306](#306) - [sdk] Fix program hanging when a resource transformation throws an exception [#307](#307) - [sdk] Fix handling of input properties with backing fields [#308](#308) ### Improvements - [sdk/auto] Implement Stack.ImportAsync() for batch importing resources into a stack [#296](#296)
algompluecker
pushed a commit
to algompluecker/pulumi-dotnet
that referenced
this pull request
Sep 4, 2024
## v3.66.0 - 2024-08-09 ### Improvements - [sdk] Support package parameterization for Read/RegisterResource/Call/Invoke [pulumi#311](pulumi#311) ### Bug Fixes - [sdk] Fix type annotations for inputListFromT0/1 [pulumi#301](pulumi#301) - [sdk] Fix race condition in GrpcMonitor's GrpcChannel management [pulumi#304](pulumi#304) - [sdk] Fix unknown inputs deserialization [pulumi#306](pulumi#306) - [sdk] Fix program hanging when a resource transformation throws an exception [pulumi#307](pulumi#307) - [sdk] Fix handling of input properties with backing fields [pulumi#308](pulumi#308) ### Improvements - [sdk/auto] Implement Stack.ImportAsync() for batch importing resources into a stack [pulumi#296](pulumi#296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix extracted from #275
I also found the same bug for unkown secrets inputs. Which is also fixed.
I did not copy the intgeration test over since that was done using a c# component provider
But it is present in the other pr, I added some unit tests to cover these edge cases though.