Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Failing crons and future token maintenance #289

Open
guineveresaenger opened this issue Jan 13, 2023 · 0 comments
Open

[internal] Failing crons and future token maintenance #289

guineveresaenger opened this issue Jan 13, 2023 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@guineveresaenger
Copy link
Contributor

Our token rotation for this provider is not automated, causing CI to fail whenever the token expires.

Discovery and fix for failures were complicated by:

  • we do not have a record of how we configure our testing environment/where resources were being created
  • tests were being skipped if the configuration variables for Actions were unset, masking longterm failures
  • test names were too generic, making debugging individual tests difficult

A lot of this has been addressed:

This token expires in 90 days.

To close out this issue, there are a few TODOs:

  1. Capture CI setup for future maintainers to find and use
  2. Long-term solution for the token
    a. Use an unexpirable token
    b. Create automation to rotate a token on the regular
    c. Add token rotation to the ops tasks
@iwahbe iwahbe added the kind/engineering Work that is not visible to an external user label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

2 participants