Upgrade terraform-provider-github to v5.12.0 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2023
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
|
401 Bad credentials [] on the Python test it seems like. |
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
While debugging tests, it was unclear which test was creating which repo. Changing the descriptions makes it easier to figure out which test to look at.
When GH_ORGANIZATION or GH_TESTING_TOKEN are expired, we should see that loudly in CI tests. Skipping tests when these are missing or misconfigured makes it seem tests are running and passing.
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
thomas11
approved these changes
Jan 13, 2023
| }, | ||
| } | ||
| } | ||
|
|
||
| func getGitHubTestingOrg(t *testing.T) string { | ||
| org := os.Getenv("GH_ORGANIZATION") | ||
| if org == "" { | ||
| t.Skipf("Skipping test due to missing GH_ORGANIZATION environment variable") |
There was a problem hiding this comment.
What about local testing? Is there to way to only fail when we're running on Github?
There was a problem hiding this comment.
I'm not sure I entirely understand your question - these variables are the CI equivalent to GITHUB_OWNER and GITHUB_TOKEN from here: https://www.pulumi.com/registry/packages/github/installation-configuration/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates Go version to 1.19
Updates to latest Pulumi.
Updates to latest Terraform bridge.
Additionally adds language to integration tests to aid with future debugging
Removes test skipping in the case of missing config variables
Removes deprecated
organizationfield in tests to useownerinstead.Fixes #275
Supersedes #277