Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-github to v5.25.0 #355

Conversation

guineveresaenger
Copy link
Contributor

This PR was generated via $ upgrade-provider pulumi/pulumi-github --upstream-provider-name terraform-provider-github.


Upgrading terraform-provider-github from 5.23.0 to 5.25.0.
Upgrading pulumi-terraform-bridge from v3.44.3 to v3.46.1.

Fixes #350
Fixes #346

@guineveresaenger guineveresaenger self-assigned this May 10, 2023
@guineveresaenger guineveresaenger requested review from a team and t0yv0 and removed request for a team May 10, 2023 19:25
@github-actions
Copy link

Does the PR have any schema changes?

Found 2 breaking changes:
Resource "github:index/team:Team" input "parentTeamId" type changed from "integer" to "string"
Resource "github:index/team:Team" output "parentTeamId" type changed from "integer" to "string"

New functions:

  • index/getBranchProtectionRules.getBranchProtectionRules

@t0yv0
Copy link
Member

t0yv0 commented May 10, 2023

Found 2 breaking changes:
Resource "github:index/team:Team" input "parentTeamId" type changed from "integer" to "string"
Resource "github:index/team:Team" output "parentTeamId" type changed from "integer" to "string"

This loos a little suspicious, we had trouble before with integer IDs. @guineveresaenger did you check if this is from upstream?

integrations/terraform-provider-github@c968888#diff-58b0ce8e60b89144845ac161d90151329dfbbd33fade4a4507e332cf69d5e2e1L50

Looks like yes.

@guineveresaenger guineveresaenger merged commit c5de623 into master May 10, 2023
@guineveresaenger guineveresaenger deleted the upgrade-terraform-provider-terraform-provider-github-to-v5.25.0 branch May 10, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-github to v5.25.0 Upgrade terraform-provider-github to v5.24.0
2 participants