New Type Mappings + Default ID Generator #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. `IAMPolicyMember` resources don't define a `resourceID`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I've been using this tool to import resources from our GCP into Pulumi. In the process, I defined new resource type mappings and found out the correct syntax for them for Pulumi to accept the configuration. Note that
ContainerClustersuffers from an import bug on Pulumi's side as far as I can tell; it does not seem solvable through this tool alone.Further, I split off two resource types into a new
broken_typesobject, which does not get used to populate the import JSON. TheLoggingLogSinkfrom the original codebase was moved there, as well as another resourceComputeBackendService, which I was also unable to defined the correct syntax for so GCP wouldn't return "this resource doesn't exist". From my work on the other resource types, I expect this to be a 'simple' case of properly defining the URI to the actual resource; but I wasn't able to track this definition down for the resources underbroken_types.Additionally, I added a function to generate a
resourceIDfor resources that don't define one themselves in the YAML output fromconfig-connector. E.g.IAMPolicyMemberresources don't define aresourceIDout-of-the-box.P.S.
I tried to rebase and clean up my commits but the commit history in this PR refuses to accept my efforts when it comes to the commits made on 11th of August (
8dac1f8,ab4ee52andd46bbd4) and the first one from Aug 15th (086da78), even though those are superseded by / made irrelevant by the later commits... blame it on my (lack of) git-fu 🙈