Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await.untilCoreV1ServiceAccountInitialized panic #3166

Closed
blampe opened this issue Aug 15, 2024 · 0 comments · Fixed by #3169
Closed

await.untilCoreV1ServiceAccountInitialized panic #3166

blampe opened this issue Aug 15, 2024 · 0 comments · Fixed by #3169
Assignees
Labels
impact/panic This bug represents a panic or unexpected crash kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer

Comments

@blampe
Copy link
Contributor

blampe commented Aug 15, 2024

What happened?

Came across this while hacking. Not sure how to reproduce, but it looks like we assume we have a cluster version that's not always available.

    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x10605c4b4]
    goroutine 598 [running]:
    github.com/pulumi/pulumi-kubernetes/provider/v4/pkg/await.untilCoreV1ServiceAccountInitialized({{0x1089ba708, 0x140004f24b0}, {0x14005c14090, 0x8a}, {0x14003f5e2be, 0x2}, 0x1400204cd40, 0x1400015c6c0, 0x14005c405d0, 0x14005c40540, ...})
    	/home/runner/work/pulumi-kubernetes/pulumi-kubernetes/provider/pkg/await/awaiters.go:692 +0x54
    github.com/pulumi/pulumi-kubernetes/provider/v4/pkg/await.Update({{{0x1089ba708, 0x140004f24b0}, {0x1089a7640, 0x140001a06d8}, {0x14005c14090, 0x8a}, {0x14003f5e2be, 0x2}, {0x140020b2020, 0x1a}, ...}, ...})
    	/home/runner/work/pulumi-kubernetes/pulumi-kubernetes/provider/pkg/await/await.go:431 +0x644
    github.com/pulumi/pulumi-kubernetes/provider/v4/pkg/provider.(*kubeProvider).Update(0x14000516000, {0x1089ba6d0, 0x140024a11a0}, 0x14000f96120)
    	/home/runner/work/pulumi-kubernetes/pulumi-kubernetes/provider/pkg/provider/provider.go:2417 +0x9e4
    github.com/pulumi/pulumi/sdk/v3/proto/go._ResourceProvider_Update_Handler.func1({0x1089ba6d0?, 0x140024a11a0?}, {0x1083457e0?, 0x14000f96120?})
    	/home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/[email protected]/proto/go/provider_grpc.pb.go:687 +0xd0
    github.com/grpc-ecosystem/grpc-opentracing/go/otgrpc.OpenTracingServerInterceptor.func1({0x1089ba6d0, 0x140024a0780}, {0x1083457e0, 0x14000f96120}, 0x140069981e0, 0x14001d04588)
    	/home/runner/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/go/otgrpc/server.go:57 +0x2e4
    github.com/pulumi/pulumi/sdk/v3/proto/go._ResourceProvider_Update_Handler({0x1088c8b60, 0x14000516000}, {0x1089ba6d0, 0x140024a0780}, 0x14007002180, 0x1400061c420)
    	/home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/[email protected]/proto/go/provider_grpc.pb.go:689 +0x148
    google.golang.org/grpc.(*Server).processUnaryRPC(0x1400079c200, {0x1089ba6d0, 0x140024a06f0}, {0x108a12a20, 0x140004e4000}, 0x14001afc900, 0x140008f9920, 0x10c5248a8, 0x0)
    	/home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:1379 +0xb58
    google.golang.org/grpc.(*Server).handleStream(0x1400079c200, {0x108a12a20, 0x140004e4000}, 0x14001afc900)
    	/home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:1790 +0xb20
    google.golang.org/grpc.(*Server).serveStreams.func2.1()
    	/home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:1029 +0x8c
    created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 54
    	/home/runner/go/pkg/mod/google.golang.org/[email protected]/server.go:1040 +0x13c

Example

n/a

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@blampe blampe added impact/panic This bug represents a panic or unexpected crash kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer labels Aug 15, 2024
blampe added a commit that referenced this issue Aug 16, 2024
- Fixed a panic that would occur when updating `ServiceAccounts`. (#3166)
- Fixed a panic that could occur when using `clusterIdentifier` provider configuration. (#3168)
@blampe blampe closed this as completed in 84f503b Aug 16, 2024
blampe added a commit that referenced this issue Aug 16, 2024
- Fixed a panic that would occur when updating `ServiceAccounts`.
(#3166)
- Fixed a panic that could occur when using `clusterIdentifier` provider
configuration. (#3168)
lumiere-bot bot referenced this issue in coolguy1771/home-ops Aug 17, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/kubernetes](https://pulumi.com)
([source](https://togithub.com/pulumi/pulumi-kubernetes)) | dependencies
| patch | [`4.17.0` ->
`4.17.1`](https://renovatebot.com/diffs/npm/@pulumi%2fkubernetes/4.17.0/4.17.1)
|

---

### Release Notes

<details>
<summary>pulumi/pulumi-kubernetes (@&#8203;pulumi/kubernetes)</summary>

###
[`v4.17.1`](https://togithub.com/pulumi/pulumi-kubernetes/blob/HEAD/CHANGELOG.md#4171-August-16-2024)

[Compare
Source](https://togithub.com/pulumi/pulumi-kubernetes/compare/v4.17.0...v4.17.1)

##### Fixed

- Fixed a panic that would occur when updating `ServiceAccounts`.
([https://github.com/pulumi/pulumi-kubernetes/issues/3166](https://togithub.com/pulumi/pulumi-kubernetes/issues/3166))
- Fixed a panic that could occur when using `clusterIdentifier` provider
configuration.
([https://github.com/pulumi/pulumi-kubernetes/issues/3168](https://togithub.com/pulumi/pulumi-kubernetes/issues/3168))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4zOS4wIiwidXBkYXRlZEluVmVyIjoiMzguMzkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/panic This bug represents a panic or unexpected crash kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant