Use include-crds flags when using helm v3 #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
requested changes
May 7, 2020
|
Also need to update changelog |
lblackstone
requested changes
May 7, 2020
|
Looks like the tests surfaced an error, I'll take another look |
|
Ah, the |
# This is the 1st commit message: Use include-crds flags when using helm v3 This PR adds a mechanism to detect if helm v3 is being used when the chart is rendered. If it is, it includes the `--include-crds` flag so that the CRDs are rendered as part of the YAML stream. Fixes #1023 # The commit message #2 will be skipped: # Remove version hack # The commit message #3 will be skipped: # Remove unneeded execSync options
This PR adds a mechanism to detect if helm v3 is being used when the chart is rendered. If it is, it includes the `--include-crds` flag so that the CRDs are rendered as part of the YAML stream. Fixes #1023
|
@mikhailshilkov can you take a look at the csharp SDK changes? |
lblackstone
requested changes
May 11, 2020
mikhailshilkov
approved these changes
May 11, 2020
lblackstone
approved these changes
May 11, 2020
|
You'll probably need to run another build and push the updated SDK |
lblackstone
requested changes
May 11, 2020
lblackstone
approved these changes
May 11, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to detect if helm v3 is being used when the
chart is rendered. If it is, it includes the
--include-crdsflag sothat the CRDs are rendered as part of the YAML stream.
Fixes #1023
Proposed changes
Related issues (optional)