Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk/nodejs] Avoid circular dependencies in modules #1558

Merged
merged 4 commits into from
May 3, 2021
Merged

[sdk/nodejs] Avoid circular dependencies in modules #1558

merged 4 commits into from
May 3, 2021

Commits on May 1, 2021

  1. [sdk/nodejs] Avoid circular dependencies in modules 

    We had a circular dependency due to the `./yaml` module importing the full root module.  This led to issues like #1422.  At least in the specific case that triggered that error - we do not need to introduce the cycle.

Fixes #1422.
    @lukehoban
    lukehoban committed May 1, 2021
    Configuration menu
    Copy the full SHA
    7030c02 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Add CHANGELOG

    @lukehoban
    lukehoban committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9b342c3 View commit details
    Browse the repository at this point in the history

  2. Deterministically order imports

    @lukehoban
    lukehoban committed May 3, 2021
    Configuration menu
    Copy the full SHA
    1b0bb05 View commit details
    Browse the repository at this point in the history

  3. Simplify logic

    @lblackstone
    lblackstone committed May 3, 2021
    Configuration menu
    Copy the full SHA
    a0a6c66 View commit details
    Browse the repository at this point in the history