Enhance detection logic for patch variants

[rquitales]

Proposed Changes

This PR improves our Patch resource detection logic by removing the reliance on a hardcoded list. Hardcoded lists are fragile because new Patch resources introduced in future SDK versions, or those generated dynamically by tools like crd2pulumi, would not be recognized as Patch variants by our provider. This issue is already present with CustomResourcePatch resources, as CustomResource kinds will never be included in a hardcoded list.

The updated logic now compares the resource URN and the object's Kind. Since the token within the URN of a patch variant always follows the pattern kind + "Patch", we can use this for comparison. Previously, the logic simply checked if the URN ended in Patch, which was inaccurate due to the possibility of a Custom Resource (CR) Kind ending in Patch (e.g., "MyResourcePatch"). This would lead to the Pulumi patch variant URN being MyResourcePatchPatch.

Testing

• Added integration tests for the YAML, Node.js, and Go languages since CustomResources are overlays and not supported in YAML. Existing tests did not ensure that deleted Patch resources only removed the fields applied, and not the whole object. This behavior is now exercised as well.
• Expanded existing unit tests.

Note: I did not expand the test coverage for Python, Java, and .NET at this time, as porting the test programs for these languages requires additional effort. We may revisit and add tests for these languages in the future.

Related Issues (Optional)

Fixes: #3023

[rquitales]

This is duplicated in provider/pkg/kinds/util_test.go.

[rquitales]

The crux of the change.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 36.60%. Comparing base (1dca605) to head (d795fad).

Files	Patch %	Lines
provider/pkg/provider/provider.go	0.00%	7 Missing ⚠️
provider/pkg/await/await.go	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3102      +/-   ##
==========================================
+ Coverage   36.57%   36.60%   +0.03%     
==========================================
  Files          71       71              
  Lines        9263     9263              
==========================================
+ Hits         3388     3391       +3     
+ Misses       5536     5534       -2     
+ Partials      339      338       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blampe]

Brilliant!

[EronWright]

I don't understand how a non-patch resource of kind MyResourcePatch would work.

[rquitales]

I don't understand how a non-patch resource of kind MyResourcePatch would work.

For a non-patch resource with Kind MyResourcePatch, the urn for the non-patch variant would be something like kubernetes:gv:MyResourcePatch. The urn for the patch variant will be kubernetes:gv:MyResourcePatchPatch. The kind for both patch, and non-patch variant is always MyResourcePatch.

So, we can determine if a resource is the patch variant or not simply by checking that: kind+"Patch == pulumiResourceName.

This PR includes both unit and integration tests to showcase this behavior:
Unit test:

pulumi-kubernetes/provider/pkg/kinds/util_test.go

Lines 24 to 34 in d795fad

	name: "CustomResource with Patch suffix that is not a patch resource",
	urn: resource.NewURN("test", "test", "", "kubernetes:kuma.io/v1alpha1:MeshProxyPatch", "test"),
	kind: "MeshProxyPatch",
	want: false,
	},
	{
	name: "CustomResource with Patch suffix and is a patch resource as well",
	urn: resource.NewURN("test", "test", "", "kubernetes:kuma.io/v1alpha1:MeshProxyPatchPatch", "test"),
	kind: "MeshProxyPatch",
	want: true,
	},

Integration test (nodejs example):

pulumi-kubernetes/tests/sdk/java/testdata/patch-resources/nodejs/step2/index.ts

Lines 120 to 148 in d795fad

	const plainCRPatching = new kubernetes.apiextensions.CustomResourcePatch(
	"plain-cr-patching",
	{
	apiVersion: "patchtest.pulumi.com/v1",
	kind: "TestPatchResource",
	metadata: {
	name: plainCR.metadata.name,
	namespace: patchRscNamespace.metadata.name,
	annotations: {
	"pulumi.com/testPatchAnnotation": "patched",
	},
	},
	}
	);
	const patchCRPatching = new kubernetes.apiextensions.CustomResourcePatch(
	"patch-cr-patching",
	{
	apiVersion: "patchtest.pulumi.com/v1",
	kind: "TestPatchResourcePatch",
	metadata: {
	name: patchCR.metadata.name,
	namespace: patchRscNamespace.metadata.name,
	annotations: {
	"pulumi.com/testPatchAnnotation": "patched",
	},
	},
	}
	);