Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deployment await logic #646

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Commits on Jul 25, 2019

  1. Fix Deployment await logic

    The Deployment await logic was incorrectly checking for the
     `extensions/v1beta1` apiVersion, which was causing the
    await logic to erroneously pass for change triggered rollouts,
    even if the Deployment was invalid.
    
    The fix required two changes:
    
    1) For some reason, the resource client was defaulting to
    the `extensions/v1beta1` apiVersion, even though recent
    versions were available on the cluster. Updated the client
    to prefer newer apiVersions.
    
    2) Updated await logic for the old apiVersion to use the input
    object rather than a received watch Event. Regardless of the
    apiVersion of the received watch Event, the relevant status
    field will be missing if the Deployment was created with the
    `extensions/v1beta1` API.
    lblackstone committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    35a0467 View commit details
    Browse the repository at this point in the history