Use HELM_HOME as default if set #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/helm-home
branch
from
83b8312
to
6f75c19
Compare
pgavlin
requested changes
Dec 3, 2019
Previously, the Chart resource ignored the HELM_HOME environment variable. This value is now used as a default if set. Note that the fetch `home` option still takes precedence over HELM_HOME.
lblackstone
force-pushed
the
lblackstone/helm-home
branch
from
6f75c19
to
4c924a4
Compare
lblackstone
force-pushed
the
lblackstone/helm-home
branch
from
4c924a4
to
11d2654
Compare
pgavlin
approved these changes
Dec 3, 2019
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, the Chart resource ignored the HELM_HOME
environment variable. This value is now used as a default
if set. Note that the fetch
homeoption still takesprecedence over HELM_HOME.
Related issues (optional)
Fixes #854