Patch vlan profiles to fix wrong diff #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
added
the
needs-release/patch
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Merged
VenelinMartinov
removed
the
needs-release/patch
mjeffryes
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Will merge on the basis of @VenelinMartinov's manual testing
Comment on lines
+15
to
+16
| - Computed: true, | ||
| Optional: true, |
There was a problem hiding this comment.
based on your PR description, I'm confused why we don't need to remove Optional: true as well; if name has to be set by the user it's not optional right?
|
This PR has been shipped in release v0.2.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #97 with a patch while we resolve the underlying bridge issue.
I've set the
nameproperty on thevlan_namesto be non-computed - this works around the bridge issue.I believe this patch is perfectly safe to take - name is not really computed - the resource does not actually work if not specified.