support access token refresh #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhlba91
force-pushed
the
feat/token-refresh
branch
from
044610e
to
c7898b2
Compare
|
@pgavlin @komalali @glena could you please review this change? as #176 describes the access token resource gets deleted from the stack upon a refresh; this change fixes that and keeps the token in the state as long as the token ID still exists. |
muhlba91
changed the title
|
Thanks so much for the contribution @muhlba91! |
|
/run-acceptance-tests |
komalali
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the missing code for successfully refreshing an access token without it getting removed from the state.
this PR fixes #176.