Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding update functionality to Deployment Settings resource #298

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Adding update functionality to Deployment Settings resource #298

merged 1 commit into from
Jun 6, 2024

Conversation

IaroslavTitov
Copy link
Contributor

Summary

  • Adding update functionaity using the new replace endpoint for DeploymentSettings

Testing

  • Manual test using Dotnet SDK

@IaroslavTitov IaroslavTitov mentioned this pull request Jun 5, 2024
Closed
@IaroslavTitov IaroslavTitov force-pushed the iaro/updateds branch 2 times, most recently from 0b907b4 to f05d4db Compare June 5, 2024 22:10
@IaroslavTitov IaroslavTitov marked this pull request as ready for review June 5, 2024 22:19
komalali
komalali reviewed Jun 5, 2024
View reviewed changes
provider/pkg/provider/deployment_settings.go Outdated
"organization": true,
"project": true,
"stack": true,
"sourceContext": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to replace on source. We should still be able to just update.

komalali
komalali reviewed Jun 5, 2024
View reviewed changes
provider/pkg/provider/deployment_settings.go Outdated
Replaces: replaces,
DetailedDiff: detailedDiffs,
HasDetailedDiff: true,
DeleteBeforeReplace: len(replaces) > 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW you can just set this to true, it'll only be needed in the case of a replace and we'll want it to be true if it is.

@IaroslavTitov IaroslavTitov merged commit dac7365 into main Jun 6, 2024
13 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/updateds branch June 6, 2024 17:29
@IaroslavTitov IaroslavTitov mentioned this pull request Jun 6, 2024
Closed
@IaroslavTitov IaroslavTitov mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komalali komalali komalali approved these changes

@pgavlin pgavlin Awaiting requested review from pgavlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IaroslavTitov @komalali