Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from GetOlds to GetOldInputs to avoid having to manually remove properties #309

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

IaroslavTitov
Copy link
Contributor

Summary

  • Moving all Diff methods to compare inputs rather than final properties
  • This way we don't need to remove properties to avoid a diff, code is more straightforward

Testing

  • All the resources are checked for diff by integ tests
  • Testing envrionment resource manually

@IaroslavTitov IaroslavTitov marked this pull request as ready for review June 6, 2024 20:52
Copy link
Member

@komalali komalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IaroslavTitov why did you have to check the environment resource manually?

@IaroslavTitov
Copy link
Contributor Author

@IaroslavTitov why did you have to check the environment resource manually?

Oh, I didn't necessarily need to, I just had it locally already, so decided to test on it

@IaroslavTitov IaroslavTitov merged commit 64c2bac into main Jun 7, 2024
13 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/diff branch June 7, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants