Fixing Read failure of 404 from Pulumi Service #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
reviewed
Jun 10, 2024
| @@ -163,8 +164,8 @@ func (evt *PulumiServiceEnvironmentVersionTagResource) Read(req *pulumirpc.ReadR | |||
| } | |||
|
|
|||
| tag, err := evt.client.GetEnvironmentRevisionTag(ctx, input.Organization, input.Environment, input.TagName) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to read StackTag (%q): %w", req.Id, err) | |||
| if err != nil && !strings.Contains(err.Error(), "404") { | |||
There was a problem hiding this comment.
This is unfortunate! ESC client should really return a rest error here. At its core ESC is just calling the pulumi service so it should return a rest error the way the service does. Did you try using
?There was a problem hiding this comment.
Just checked, and unfortunately this does not work, because this method is trying to cast into errorResponse, but the root of the error returned by the client is just a string created with fmt.Errorf
I can create a helper method to make this check a bit more elegant, but unfortunately don't see a way around checking string for 404
There was a problem hiding this comment.
Bummer, thanks for trying it out
komalali
approved these changes
Jun 14, 2024
IaroslavTitov
force-pushed
the
iaro/tag-preview-bug
branch
from
c5dc636
to
25b150c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
###Testing