Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken tests #326

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fixing broken tests #326

merged 1 commit into from
Jun 21, 2024

Conversation

IaroslavTitov
Copy link
Contributor

@IaroslavTitov IaroslavTitov commented Jun 20, 2024

After an update to pulumi CLI, tests started failing. Most of the issues were on refresh, and refresh used to be skipped for most tests, which made it more confusing why the same test failed in yaml, but succeeded in other languages.

Summary

  • Removed SkipRefresh flags everywhere except Deployment Settings, because this is just a bandaid to make broken resources test pass (Deployment Settings are currently broken, with fix PR blocked by these tests failing)
  • Reverted req.GetOldInputs() back into req.GetOlds(), which is not a good change, but the proper way would be to overhaul how AccessTokens work (currently Diff uses internal __inputs property which should no longer be used)
  • Adjusted go and python environment yaml string to make refresh work (it's quite ugly, but we do have an issue to add auto-formatting)
  • Fixed Schedules and Environment Read() outputting properties instead of inputs, causing noisy refresh diff due to discrepancy in input and output schema (this used to be silent, became noisy after a pulumi engine update)
  • Added logic to set displayName of Team resource input to name if not supplied. This is what Pulumi Service does anyway, which caused a noisy diff

@IaroslavTitov IaroslavTitov force-pushed the iaro/temp branch 12 times, most recently from 69a558a to 8b148fa Compare June 21, 2024 21:57
@IaroslavTitov IaroslavTitov merged commit f460b27 into main Jun 21, 2024
13 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/temp branch June 21, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants