Codefreeze for 0.21.4 #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
reviewed
Jun 24, 2024
|
|
||
| ### Miscellaneous | ||
|
|
||
| - Fixed integ tests [#328](https://github.com/pulumi/pulumi-pulumiservice/issues/328) |
There was a problem hiding this comment.
I think the result was that this was not just fixing the tests? There were meaningful bug fixes included in this change. Can we please capture what we fixed for end users?
There was a problem hiding this comment.
Updated to include bug #319, which was also fixed during the PR that fixed integ tests.
IaroslavTitov
force-pushed
the
iaro/codefreeze
branch
from
9b80fe0
to
daa1a06
Compare
komalali
approved these changes
Jun 24, 2024
CHANGELOG.md
Outdated
| ### Miscellaneous | ||
|
|
||
| - Fixed integ tests [#328](https://github.com/pulumi/pulumi-pulumiservice/issues/328) | ||
| - Fixed Environment Get function by fixing the resource's Read method [#319](https://github.com/pulumi/pulumi-pulumiservice/issues/319) |
There was a problem hiding this comment.
Should this be under Bug Fixes?
There was a problem hiding this comment.
Ah, you're right, I just added below without much thought
IaroslavTitov
force-pushed
the
iaro/codefreeze
branch
from
daa1a06
to
f2054c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.