Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing secret leak in Deployment Settings #381

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fixing secret leak in Deployment Settings #381

merged 1 commit into from
Aug 14, 2024

Conversation

IaroslavTitov
Copy link
Contributor

Summary

  • This commit unintentionally introduced code "unsercreting" all the inputs, which is what resulted in a leak
  • Other values that are forced to be secrets (like github passwords) were not affected, which has covered up this issue during tests

Testing

  • Manually tested, verified secrets and now covered up in both Pulumi Console and in stack export json

@IaroslavTitov IaroslavTitov marked this pull request as ready for review August 14, 2024 21:15
@IaroslavTitov IaroslavTitov merged commit 7227d43 into main Aug 14, 2024
14 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/bugfix branch August 14, 2024 21:15
@IaroslavTitov IaroslavTitov mentioned this pull request Aug 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanyeh seanyeh seanyeh approved these changes

@dschaller dschaller Awaiting requested review from dschaller

@komalali komalali Awaiting requested review from komalali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IaroslavTitov @seanyeh