Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a python test for agent pools #396

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

komalali
Copy link
Member

@komalali komalali commented Aug 26, 2024

No description provided.

@komalali komalali changed the title Add a python test for extra certainty Add a python test for agent pools Aug 26, 2024
@komalali komalali added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Aug 26, 2024
@komalali komalali force-pushed the komal/fix-agent-pool-refresh branch from 382a06e to 8a4c184 Compare August 26, 2024 23:49
@komalali komalali marked this pull request as ready for review August 27, 2024 00:17
@komalali komalali force-pushed the komal/fix-agent-pool-refresh branch from 8a4c184 to ad536a9 Compare August 29, 2024 17:28
@komalali komalali requested a review from a team August 29, 2024 19:37
Copy link
Contributor

@seanyeh seanyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Do we want to add agent pool examples for other languages?

@komalali
Copy link
Member Author

@seanyeh I added one for YAML earlier and added this one because the reported case was specifically a Python example. I think just these are good enough for now.

@komalali komalali merged commit 45b952e into main Aug 29, 2024
13 checks passed
@komalali komalali deleted the komal/fix-agent-pool-refresh branch August 29, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants