Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename example template #417

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Rename example template #417

merged 1 commit into from
Sep 25, 2024

Conversation

seanyeh
Copy link
Contributor

@seanyeh seanyeh commented Sep 25, 2024

Fix #408

@seanyeh seanyeh marked this pull request as ready for review September 25, 2024 23:41
@@ -5,4 +5,6 @@
- Fixes failing pulumi refresh on org tokens with a slash in its name [#388](https://github.com/pulumi/pulumi-pulumiservice/issues/388)
- Fix panic when using computed values in environment definition [#411](https://github.com/pulumi/pulumi-pulumiservice/issues/411)

- Fix failing build due to conflicting resource names [#408](https://github.com/pulumi/pulumi-pulumiservice/issues/408)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure on conventions here but I feel like generally changelogs don't include things like example or test updates

@seanyeh seanyeh added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Sep 25, 2024
@seanyeh seanyeh merged commit 69144a3 into main Sep 25, 2024
13 checks passed
@seanyeh seanyeh deleted the syeh/fix-flaky-build branch September 25, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: main
2 participants