Fix tf2pulumi renames

This PR moves an invalid mapping in the `pkg/tf2pulumi/convert/testdata/mappings/renames.json` to a valid mapping. You can see the newly valid mapping take effect in the schema file: `pkg/tf2pulumi/convert/testdata/schemas/renames.json`. This PR exposes a bug where tf2pulumi doesn't properly propagate `MaxItems: 1` information. The bug is shown in the changes in `pkg/tf2pulumi/convert/testdata/renames/pcl/main.pp`.
pulumi · Aug 14, 2024 · 7d28415 · 7d28415
1 parent 5ef404f
commit 7d28415
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/pkg/tf2pulumi/convert/testdata/mappings/renames.json b/pkg/tf2pulumi/convert/testdata/mappings/renames.json
@@ -82,9 +82,11 @@
                 },
                 "a_resource": {
                     "name": "theResource",
-                    "fields": {
-                        "inner_string": {
-                            "name": "theInnerString"
+                    "element": {
+                        "fields": {
+                            "inner_string": {
+                                "name": "theInnerString"
+                            }
                         }
                     }
                 },

diff --git a/pkg/tf2pulumi/convert/testdata/renames/pcl/main.pp b/pkg/tf2pulumi/convert/testdata/renames/pcl/main.pp
@@ -1,7 +1,7 @@
 resource aResource "renames:index/index:resource" {
     theNumber = 1
     theResource = {
-        theInnerString = "hello"
+        innerString = "hello"
     }
 }
 output someOutputA {
@@ -34,6 +34,6 @@
 }
     theNumber = 1
     theResource = {
-        theInnerString = "hello"
+        innerString = "hello"
     }
 }
diff --git a/pkg/tf2pulumi/convert/testdata/schemas/renames.json b/pkg/tf2pulumi/convert/testdata/schemas/renames.json
@@ -28,7 +28,7 @@
     },
     "renames:index/resourceTheResource:resourceTheResource": {
       "properties": {
-        "innerString": {
+        "theInnerString": {
           "type": "string"
         }
       },