Refresh pollutes state for programs that use Assets and Archives #1595
Assignees
Labels
kind/bug
Some behavior is incorrect or out of spec
resolution/fixed
This issue was fixed
size/S
Estimated effort to complete (1-2 days).
Milestone
Comments
t0yv0
added
needs-triage
|
Seeing lots of incidences in azure tests as well. Any time azure:storage/blob:Blob is used, in particular when used with overlays that automatically provision functions like this one: export const subscription = topic.onEvent("test", async (context, arg) => { |
This was referenced Dec 27, 2023
|
I've added this bug to the planning sheet for next iteration. |
t0yv0
added a commit
that referenced
this issue
Feb 2, 2024
Fixes #1595, https://github.com/pulumi/pulumi/issues/6235 Before this change, refreshing an unchanged resource which used an Asset or an Archive resulted in polluting Pulumi state with a machine-local filename. The simplest example this is tested on is: ```typescript const exampleBucketObject = new aws.s3.BucketObject("exampleBucketObject", { key: "someobject", bucket: bucket.id, source: new pulumi.asset.FileAsset(inFile), }); ``` After this change this example refreshes correctly with no changes detected. Unfortunately this change by itself is insufficient to guarantee that these resources refresh correctly when Pulumi-tracked state is out of date with respect to the cloud state, and further work is required to make this correct for individual resources in each provider. For the example above, the upstream provider for BucketObject does not implement fetching contents of the object upon Read into a temporary file. Therefore refreshing the object in this situation updates the "etag" property but does not guide the user to the need of reconciling the FileAsset with the updated cloud state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
When using assets and archives, as common for lambas in AWS for example, refresh wipes out the asset/archive information from the state and replaces it with machine-local references. This is inherently dangerous if multiple boxes are used to perform
pulumioperations against a shared statefile.Example
The motivating example is a highly upvoted issue in pulumi-aws:
pulumi/pulumi-aws#3548
pulumi/pulumi-aws#3185 even more minimal repro is here.
Output of
pulumi aboutSee above.
Additional context
N/A
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: