Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestConvert fails on Windows CI runners #408

Closed
t0yv0 opened this issue Oct 29, 2021 · 1 comment
Closed

TestConvert fails on Windows CI runners #408

t0yv0 opened this issue Oct 29, 2021 · 1 comment
Labels
area/docsgen Issues with docs capture or example rendering, historically part of pkg/tfgen impact/panic This bug represents a panic or unexpected crash kind/engineering Work that is not visible to an external user resolution/wont-fix This issue won't be fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 29, 2021

Hello!

  • Vote on this issue by adding a 👍 reaction
  • To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

The new TestConvert test is currently skipped on windows. It is passing on other systems. Would be good to understand why we get this:

=== RUN   TestConvert
=== RUN   TestConvert/regress_cannot_bind_expression
=== CONT  TestConvert
    convert_test.go:94: fixHcl left intact: 
                          variable "region_number" {
                            default = {
                              us-east-1 = 1
                            }
                          }
        
                          resource "aws_vpc" "example" {
                            cidr_block = cidrsubnet("10.0.0.0/8", 4, 2)
                          }
--- FAIL: TestConvert (0.00s)
    --- FAIL: TestConvert/regress_cannot_bind_expression (0.00s)
panic: fatal: An assertion has failed [recovered]
	panic: fatal: An assertion has failed

Steps to reproduce

Expected:
Actual:

@t0yv0 t0yv0 added the kind/bug Some behavior is incorrect or out of spec label Oct 29, 2021
@t0yv0 t0yv0 mentioned this issue Oct 29, 2021
@jkodroff jkodroff added the area/tfgen Issues in pkg/tgen, excluding docs generation - use area/docsgen for those label Jun 22, 2022
@t0yv0 t0yv0 added kind/engineering Work that is not visible to an external user area/docsgen Issues with docs capture or example rendering, historically part of pkg/tfgen and removed kind/bug Some behavior is incorrect or out of spec area/tfgen Issues in pkg/tgen, excluding docs generation - use area/docsgen for those labels Apr 5, 2023
@t0yv0 t0yv0 added the impact/panic This bug represents a panic or unexpected crash label Jul 7, 2023
@t0yv0 t0yv0 added the resolution/wont-fix This issue won't be fixed label Mar 1, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Mar 1, 2024

The system under test will soon no longer be in use here, closing.

@t0yv0 t0yv0 closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docsgen Issues with docs capture or example rendering, historically part of pkg/tfgen impact/panic This bug represents a panic or unexpected crash kind/engineering Work that is not visible to an external user resolution/wont-fix This issue won't be fixed
Projects
None yet
Development

No branches or pull requests

2 participants