[Epic] Switch all tfgen uses to the new converter #1280
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
To be reviewed with pulumi/pulumi-azuread#484 Part of pulumi/pulumi-terraform-bridge#1280 As a pre-requisite to PULUMI_CONVERT being enabled, it's necessary to pin Pulumi CLI so that examples continue to be deterministic. This PR borrows targets from pulumi-azure-native that perform CLI pinning. ## Updates ### CLI Unlike azure-native, it assumes that the CLI version we want to use to convert examples is the same as pulumi/pkg version we want to use to build this provider. This removes a degree of freedom but buys automatic upgrades - the existing mechanisms that update pulumi/pkg (in upgrade-provider) should also update this Pulumi CLI version. ### Converter This is not enforced here but pulumi/pulumi-azuread#484 adds TF converter pinning to the CI-mgmt plugins section. This PR makes changes to allow opting into converter and not just resource plugins. There is currently no mechanism to upgrade this, but presumably upgrade-provider can build mechanisms to upgrade all plugins referenced in this config file. Any such upgrade is likely to trigger the need to regenerate SDKs.
mnlumi
changed the title
|
@cnunciato kindly agreed to help out making provider registry builds to help validate the Tier 1 PRs. But unfortunately since that conversation I started rebasing the PRs and hit a new blocker. pulumi/pulumi#14718 I believe Fraser is looking at this presently. |
|
Blocked on pulumi/pulumi-yaml#539 |
|
This just shipped so we should be unblocked! Wonderful news. |
It merged, we need to do a yaml and pulumi release still. |
|
Almost there, next pulumi release I can finish this off for the Tier1 providers at least I believe. |
|
Another round of iteration, Fraser unblocked another problem (🙇 ), the latest version of the converter gives non-deterministic build results again, digging into that tomorrow. That seems like the last known blocker-level problem for rolling out to tier1. |
|
pulumi/pulumi-azure#1377 PR is in the best shape of how this looks like (latest version). |
|
AFAIK all our providers have migrated (perhaps need to check two newly added ones like meraki CC @mjeffryes). Exploring cleanup in #2004 that would propagate the change out to bridged providers outside of Pulumi org. |
|
Wrote comms #2037 we should circulate and get feedback on before pulling the trigger. |
|
Per conversation with @mjeffryes , closing as completed and tracking comms+cleanup in a new epic https://github.com/pulumi/home/issues/3452 |
|
Cannot close issue:
Please fix these problems and try again. |
This epic tracks rollout of Terraform to Pulumi example converter to improve coverage and quality of examples in Registry.
https://docs.google.com/document/d/1FRQAJd17sTjfKYVhfuN9N9AtZNfRLlQv37-sIwEnDyA/edit?usp=sharing
Work Items ⚙️
Tier 2 Provider Upgrade Procedure
Since there are many of these we will use a simplified procedure. ci-mgmt will be updated to set PULUMI_CONVERT=true and ensure Pulumi CLI is pinned; then these providers will receive the improved converter during routine updates as they pull in new tfbrdige versions. Apparently there is a system in place that tracks example cov metrics on S3, so we can monitor the process using this system.
Associated Docs Bugs
Fixes #1399
The text was updated successfully, but these errors were encountered: