[PF] Allow overriding Number with String for PF fields #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2155 +/- ##
========================================
Coverage 60.65% 60.65%
========================================
Files 350 352 +2
Lines 45930 46050 +120
========================================
+ Hits 27857 27930 +73
- Misses 16533 16573 +40
- Partials 1540 1547 +7 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Jul 3, 2024
iwahbe
force-pushed
the
iwahbe/enable-int-id-for-pf
branch
from
d14eebf
to
104494b
Compare
iwahbe
force-pushed
the
iwahbe/enable-int-id-for-pf
branch
from
104494b
to
752fc0b
Compare
iwahbe
added a commit
to pulumi/pulumi-dnsimple
that referenced
this pull request
Jul 16, 2024
iwahbe
added a commit
to pulumi/pulumi-dnsimple
that referenced
this pull request
Jul 16, 2024
iwahbe
added a commit
to pulumi/pulumi-dnsimple
that referenced
this pull request
Jul 16, 2024
iwahbe
added a commit
to pulumi/pulumi-dnsimple
that referenced
this pull request
Jul 16, 2024
|
This PR has been shipped in release v3.87.0. |
iwahbe
added a commit
to pulumi/pulumi-dnsimple
that referenced
this pull request
Jul 17, 2024
iwahbe
added a commit
to pulumi/pulumi-dnsimple
that referenced
this pull request
Jul 17, 2024
iwahbe
added a commit
to pulumi/pulumi-dnsimple
that referenced
this pull request
Jul 19, 2024
* WIP Initial mapping to PF * Apply ID type overrides Depends on pulumi/pulumi-terraform-bridge#2155. * make build_sdks * Add explanation in resources.go for the ID insertion * Remove the overlay in favor of extra types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by
terraform-provider-vantage blocked on numeric ID support #1198. My plan for #1198 is to override the "id" fields of each resource to be a"string", which is how we currently handle SDK based providers with the same problem.