Typos and simplified logic #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The body is `tfbridge.IsMaxItemsOne` is:
```go
func IsMaxItemsOne(tfs shim.Schema, info *SchemaInfo) bool {
if tfs == nil {
return false
}
if tfs.Type() != shim.TypeList && tfs.Type() != shim.TypeSet {
return false
}
if info != nil && info.MaxItemsOne != nil {
return *info.MaxItemsOne
}
return tfs.MaxItems() == 1
}
```
Thus, checking if `tfs` is of `shim.Type{List,Set}` before calling
`tfbridge.IsMaxItemsOne` is redundant.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2313 +/- ##
==========================================
- Coverage 56.87% 56.86% -0.01%
==========================================
Files 365 365
Lines 49964 49962 -2
==========================================
- Hits 28415 28413 -2
Misses 20004 20004
Partials 1545 1545 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 typos and removes a redundant check. 372e0ba contains a message explaining why it is safe.
Refactored out of #2309.