Refined ProposedNew #703
Merged
Refined ProposedNew #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff for pulumi-random with merge commit 1615e2e |
|
Diff for pulumi-azuread with merge commit 1615e2e |
|
Diff for pulumi-gcp with merge commit 1615e2e |
|
Diff for pulumi-azure with merge commit 1615e2e |
|
Diff for pulumi-aws with merge commit 1615e2e |
t0yv0
force-pushed
the
t0yv0/objchange-proposed-new
branch
from
644c5a1
to
c49f556
Compare
|
Diff for pulumi-random with merge commit 1938ae7 |
|
Diff for pulumi-azuread with merge commit 1938ae7 |
|
Diff for pulumi-gcp with merge commit 1938ae7 |
|
Diff for pulumi-azure with merge commit 1938ae7 |
|
Diff for pulumi-aws with merge commit 1938ae7 |
|
Diff for pulumi-azuread with merge commit 586be32 |
|
Diff for pulumi-random with merge commit 586be32 |
|
Diff for pulumi-azure with merge commit 586be32 |
|
Diff for pulumi-aws with merge commit 586be32 |
t0yv0
requested review from
jazzyfresh
and removed request for
danielrbradley and
roothorp
jazzyfresh
approved these changes
Jan 19, 2023
Base automatically changed from
t0yv0/tfpf-recognize-blocks
to
t0yv0/tfpf-stubs
January 20, 2023 02:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the TLS provider, the bridge failed to create resources that are both Computed and Optional at the same time. There was a bit of a rabbit hole with the ProposedNew calculation, the PR updates links to the likely reference source in TF. Unfortunately there's a bit of complexity there about merging priorStateValue and configValue in the Computed+Optional case, merging is recursive.
What I ended up going with is porting test cases from a likely reference TF implementation (cross-linked) and refining the current implementation to pass the test cases. There's still possibility that the implementations diverge in corner cases not covered by the test suite, but this should be good enough for many cases - hitting diminishing returns. If we have more bug reports stating discrepancy might be worth to rewrite the ProposedNew again but as a direct port of the reference code (structurally matching).