Skip to content
This repository has been archived by the owner on Dec 24, 2023. It is now read-only.

Add wait_for_steady_state #18

Merged
merged 2 commits into from
Feb 22, 2018
Merged

Add wait_for_steady_state #18

merged 2 commits into from
Feb 22, 2018

Conversation

mmdriley
Copy link
Contributor

Port of hashicorp/terraform-provider-aws#3485 onto pulumi-master. Too early to tell if, or in what form, this will land upstream but it's useful as-is to us now.

If true, creates and updates will only complete once the service has
reached a steady state.
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For the upstream PR, we may need to add a TF test case - though that shouldn't block us from adopting ourselves and getting experience using it.

@mmdriley
Copy link
Contributor Author

I left a comment upstream about a test -- I wanted to add one, but I couldn't come up with something likely to provide useful coverage and even the not-useful tests are expensive. If they push back I'll think harder. :)

@mmdriley mmdriley merged commit 88178bc into pulumi-master Feb 22, 2018
@mmdriley mmdriley deleted the wait-for-services branch February 22, 2018 19:44
mmdriley added a commit to pulumi/pulumi-aws that referenced this pull request Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants