253 Add Java & YAML support #256
Conversation
|
Hey there @Asamsig ! Thanks for this PR! Would you mind adding an entry in the CHANGELOG for your PR? |
|
It looks like bumping the version here resulted in a breaking change in CI. Did you manage to test this locally and get it to work? Thank you again for your contribution. :) |
RobbieMcKinstry
added
kind/enhancement
|
I'll take a look at the changelog. Hmm, I'll take another look, I was able to verify Java and Yaml worked, but perhaps it broke something I didn't test. |
Ran `go mod tidy -go=1.16 && go mod tidy -go=1.17` to specify indirect dependency tree Updated GIthub Actions scripts to use Go 1.17 to build the project
Asamsig
force-pushed
the
253-add-java--yaml-support
branch
from
8176682
to
e6a8274
Compare
|
Seems that the problem was that Pulumi-yaml requires Go 1.17, and Github actions was only using 1.16. |
|
Hmm, I wonder if this failure related to pulumi/pulumi-docker-containers#98 If so, a workaround is to have a Pulumi employee push this changeset to a branch and running CI there instead of from the fork. |
| @@ -1,22 +1,212 @@ | |||
| module github.com/pulumi/tf2pulumi | |||
|
|
|||
| go 1.16 | |||
| go 1.17 | |||
There was a problem hiding this comment.
@Asamsig I think you need to run go mod tidy on the repo to clean this file up. I could be wrong though.
There was a problem hiding this comment.
I actually did run go mod tidy, if you look in pulumi-terraform-bridge, it has gotten a similar massive indirect dependency tree. 😅
There was a problem hiding this comment.
Ah, okay, well, it is what it is then! 😅 👍🏻
|
Merged as #260 |
#253
Updated pulumi-terraform-bridge version to enable Java and YAML support