Do not upgrade forked terraform-plugin-sdk ahead of the bridge #243
Assignees
Labels
Milestone
Comments
t0yv0
added
kind/bug
|
https://github.com/pulumi/pulumi-gcp/pull/1638/files#diff-0301265a2d4321ca487bbd7ba523f69633171cef680c0114e7ca8d2c34176b73R19 another one.. I was updating GCP to do a simple minor update and looks like the terraform-plugin-sdk is updating as part of it. That's a bit suspect. |
|
OK this is causing failure to pre-test bridge upgrade with a given sdk version --target-bridge-version: 45cdb2507f387f34af187ca4021076549cbbf78e pulumi/pulumi-github#559 and more |
t0yv0
added a commit
that referenced
this issue
Feb 8, 2024
Fixes #243 After this change the terraform SDK v2 override follows the replace from the selected bridge version exactly. I think this is what we want - this is compensating for the inability of Go tooling to propagate the replace to dependencies. The change also starts to unconditionally insert this replace. This is because on the latest bridge tfgen somehow depends on sdkv2 and even providers such as pulumi-random that presumably do not need sdkv2 now depend on it and need the replace accordingly, see pulumi/pulumi-random#687 for example.
t0yv0
added a commit
that referenced
this issue
Feb 9, 2024
Quick fix for a panic introduced in #243 Would like to merge to prevent p1s, follow up with tests later. Verified this works on pulumi-azuread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Per conversation in https://github.com/pulumi/upgrade-provider/pull/242/files it appears that maybe/possibly we're upgrading the fork of terraform-plugin-sdk to the latest from GitHub. That's may be a good option to have but it's not a good default. By default we should be trying to match whatever the bridge has when upgrading the bridge, because that is the version the bridge was tested with. Unfortunately go tooling does not make this trivial, but something along the lines of finding bridge sources and finding the go mod replace directive from those sources that the bridge was built with could do the trick. If helpful we can lift this to a text file in the bridge somehow.
Example
N/A
Output of
pulumi aboutN/A
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: