Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error #73

Closed
Petterholm opened this issue Jan 28, 2016 · 27 comments
Closed

error #73

Petterholm opened this issue Jan 28, 2016 · 27 comments

Comments

@Petterholm
Copy link

I get an error when running a bot script it looks like a agario-client error
https://gyazo.com/7979b459a50db12e0befe84d455395c0

@pulviscriptor
Copy link
Owner

If you use SOCKS you need to add on.packetError listener and preventCrash() in it #46 (comment)
Also you need manually to fix ws crashes until in get fixed in repo websockets/ws#669
All these problems because buggy public SOCKS servers that breaks packets and sends random data sometimes.

@Petterholm
Copy link
Author

i dont use socks proxies

@pulviscriptor
Copy link
Owner

Okay, then we have a problem.
How often you see those crashes and what version of agario-client you have? You can check it in npm list

@Petterholm
Copy link
Author

I see them after running my bots maybe 2 to 3 minutes.
https://gyazo.com/81602225ef87e94d6421a3829475b808

@pulviscriptor
Copy link
Owner

I can not reproduce it so i need that broken packet from you.
Do something like

client.on('packetError', function(packet) {
   console.log('Report this packet: ' + packet.toString());
});

After that you will see packet in console, bring it here so i can look at it.

@Petterholm
Copy link
Author

where am i supposed to write that?

@pulviscriptor
Copy link
Owner

Where you have all your events attached, attach this one too.

@Petterholm
Copy link
Author

where do i have that?

@Petterholm
Copy link
Author

in node-modules?

@pulviscriptor
Copy link
Owner

@Petterholm
Uhm... Did you made your bot yourself?
If not, you probably should ask help from guy who gave you your bot. Tell him to attach that event.

@Petterholm
Copy link
Author

@pulviscriptor
Copy link
Owner

@Petterholm
Are you sure you do not using SOCKS/proxy? I see that bot is supporting it.

@Petterholm
Copy link
Author

@Petterholm
Copy link
Author

proxies*

@Petterholm
Copy link
Author

do socks crash it?

@pulviscriptor
Copy link
Owner

do socks crash it?

Yes they do. You need to create issue in that repo to make fix for it.

@pulviscriptor
Copy link
Owner

Go there https://github.com/davidmann4/agario-feeder-bot/issues and create issue about bad socks breaking packets.
You can refer my investigation #56 (comment)
Authors of that bot need to add on.packetError and do preventCrash()

@Petterholm
Copy link
Author

could you make it? i dont really understand what i am supposed to write

@pulviscriptor
Copy link
Owner

Sure. I will create it.

@Petterholm
Copy link
Author

thx

@pulviscriptor
Copy link
Owner

@Petterholm
We need your help.
@WJKH in issue inagario-feeder-bot told me that bot supports only proxy without SOCKS, so i need to see your packets to check if proxy have same issues as SOCKS or there is bug in agario-client.
Open locally this file https://github.com/davidmann4/agario-feeder-bot/blob/master/feeder.js#L66 and replace

        bot.client.on('connectionError', function(e) {
            if (config.verbosityLevel > 0) {
                bot.log('Connection Failed: ' + e);
            }
        });


        bot.client.on('myNewBall', function(ball_id) {
            // Should always be generated.
            if (config.verbosityLevel > -1) {
                bot.log('New Cell Generated (' + ball_id + ')');
            }
        });

with

        bot.client.on('connectionError', function(e) {
            if (config.verbosityLevel > 0) {
                bot.log('Connection Failed: ' + e);
            }
        });

bot.client.on('packetError', function(packet) {
   console.log('Report this packet: ' + packet.toString());
});

        bot.client.on('myNewBall', function(ball_id) {
            // Should always be generated.
            if (config.verbosityLevel > -1) {
                bot.log('New Cell Generated (' + ball_id + ')');
            }
        });

On crash you will see packet that caused crash, post it here. Better to post 3-6 packets.
Thank you.

@Petterholm
Copy link
Author

I will do it in 1-2 hours

Sendt fra min iPhone

Den 30. jan. 2016 kl. 01.41 skrev pulviscriptor [email protected]:

@Petterholm
We need your help.
@WJKH in issue inagario-feeder-bot told me that bot supports only proxy without SOCKS, so i need to see your packets to check if proxy have same issues as SOCKS or there is bug in agario-client.
Open locally this file https://github.com/davidmann4/agario-feeder-bot/blob/master/feeder.js#L66 and replace

    bot.client.on('connectionError', function(e) {
        if (config.verbosityLevel > 0) {
            bot.log('Connection Failed: ' + e);
        }
    });


    bot.client.on('myNewBall', function(ball_id) {
        // Should always be generated.
        if (config.verbosityLevel > -1) {
            bot.log('New Cell Generated (' + ball_id + ')');
        }
    });

with

    bot.client.on('connectionError', function(e) {
        if (config.verbosityLevel > 0) {
            bot.log('Connection Failed: ' + e);
        }
    });

bot.client.on('packetError', function(packet) {
console.log('Report this packet: ' + packet.toString());
});

    bot.client.on('myNewBall', function(ball_id) {
        // Should always be generated.
        if (config.verbosityLevel > -1) {
            bot.log('New Cell Generated (' + ball_id + ')');
        }
    });

On crash you will see packet that caused crash, post it here. Better to post 3-6 packets.
Thank you.


Reply to this email directly or view it on GitHub.

@Petterholm
Copy link
Author

@pulviscriptor
Copy link
Owner

@Petterholm
Can you report more packets and copy/paste them as text please?
Like this: 10 E7 FB FF FF F0 FC FF FF 00 00 00 00

@Petterholm
Copy link
Author

I will do it soon

Den lørdag 30. januar 2016 skrev pulviscriptor [email protected]
følgende:

@Petterholm https://github.com/Petterholm
Can you report more packets and copy/paste them as text please?
Like this: 10 E7 FB FF FF F0 FC FF FF 00 00 00 00


Reply to this email directly or view it on GitHub
#73 (comment)
.

@Petterholm
Copy link
Author

How can i get more?

Sendt fra min iPhone

Den 30. jan. 2016 kl. 18.15 skrev pulviscriptor [email protected]:

@Petterholm
Can you report more packets and copy/paste them as text please?
Like this: 10 E7 FB FF FF F0 FC FF FF 00 00 00 00


Reply to this email directly or view it on GitHub.

@pulviscriptor
Copy link
Owner

@Petterholm
Just run it again and you get new packet. Repeat it few times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants