fix(launcher): support https for browserURL endpoint #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How's this possible? Do I understand correctly that k8s launches a chrome instance with a remote debugging exposed on a particular port, and then this port is re-exposed with K8s over https? |
|
@aslushnikov ah sorry, actually https is enforced on a different level for our whole infra. But yeah, in general we deploy a container with a puppeteer w/ remote debugging enabled to k8s. There's minor hijack required to compensate #2242, but overall it works as expected :) |
aslushnikov
approved these changes
Apr 11, 2019
|
@aslushnikov thanks! |
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
We'd like to deploy Puppeteer to internal Kubernetes (which serves everything via https, at least in our setup), but apperently
browserURLis limited to http requests at the moment. I wonder if there's any particular reason behind it?I'm not sure how to setup https case for testing, but happy to work on it with some guidance.
Thanks!