Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-186) Handle missing Project URI in PowerShell module metadata #187

Merged
merged 1 commit into from
Jul 7, 2021
Merged

(GH-186) Handle missing Project URI in PowerShell module metadata #187

merged 1 commit into from
Jul 7, 2021

Conversation

michaeltlombardi
Copy link

@michaeltlombardi michaeltlombardi commented Jul 7, 2021 •
edited
Loading

Resolves #186

@michaeltlombardi michaeltlombardi added the bug Something isn't working label Jul 7, 2021
@michaeltlombardi michaeltlombardi requested a review from a team as a code owner July 7, 2021 15:32
@michaeltlombardi
(GH-186) Handle missing project uri in metadata
e0ab9c5 
Prior to this commit, valid PowerShell modules on the PowerShell Gallery
were sometimes un-Puppetizable as they were missing the `ProjectUri`
metadata key in their manifest.

This commit modifies the logic in the `Get-ReadmeContent` private
function to reuse the module's PowerShell Gallery URI if the Project URI
is null or empty, ensuring that modules with this missing metadata are
Puppetizable.
@michaeltlombardi michaeltlombardi changed the title (WIP) Handle missing Project URI in PowerShell module metadata (GH-186) Handle missing Project URI in PowerShell module metadata Jul 7, 2021
@sanfrancrisko sanfrancrisko merged commit 081a2c0 into puppetlabs:main Jul 7, 2021
@michaeltlombardi michaeltlombardi deleted the gh-186/main/build-with-missing-project-uri branch July 7, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfrancrisko sanfrancrisko sanfrancrisko approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot Puppetize modules missing their Project URI
2 participants
@michaeltlombardi @sanfrancrisko