(CONT-257) Add PDKTemplateRef parameter #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
CONT-257-add_pdk_template_ref_param
branch
from
3ce9862
to
f062a03
Compare
Prior to this commit it was not possible to specify the version of pdk-templates that would be used when puppetizing a Dsc module. PDK help sugegsts that the default ref is 2.5.0, however in practice it would pull down the latest tag from the pdk-templates repository. At the time of commit, this was 2.6.0. The above diff causes some issues when puppetizing a resource due to gem incompatibilities. This commit adds a new parameter called PDKTemplateRef to `New-PuppetDscModule` and `Initialize-PuppetModule` so that users can optionally provide a different pdk-templates version. The default value has been set to 2.5.0.
chelnak
force-pushed
the
CONT-257-add_pdk_template_ref_param
branch
from
f062a03
to
543ec44
Compare
GSPatton
approved these changes
Nov 3, 2022
|
rerunning stuck tests |
|
2016 tests failing due to the runner being deprecated |
2016 runners have now been removed. This commit adds 2022 runners and removes 2016 runners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit it was not possible to specify the version of pdk-templates that would be used when puppetizing a Dsc module.
PDK help sugegsts that the default ref is 2.5.0, however in practice it would pull down the latest tag from the pdk-templates repository. At the time of commit, this was 2.6.0.
The above diff causes some issues when puppetizing a resource due to gem incompatibilities.
This commit adds a new parameter called PDKTemplateRef to
New-PuppetDscModuleandInitialize-PuppetModuleso that users can optionally provide a different pdk-templates version.The default value has been set to 2.5.0.