Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) - Update PDK Install #257

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

jordanbreen28
Copy link

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 added the maintenance non-user-visible changes improving the infrastructure label Aug 2, 2023
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner August 2, 2023 10:50
@jordanbreen28 jordanbreen28 force-pushed the maint-update_puppetize_workflow branch 15 times, most recently from b86a365 to 2156915 Compare August 2, 2023 16:16
@jordanbreen28 jordanbreen28 force-pushed the maint-update_puppetize_workflow branch from 2156915 to 6378c8a Compare August 2, 2023 17:06
@GSPatton GSPatton marked this pull request as draft August 9, 2023 08:45
@GSPatton
Copy link

GSPatton commented Aug 9, 2023

do not merge. Waiting for updates to Bolt

@jordanbreen28 jordanbreen28 force-pushed the maint-update_puppetize_workflow branch 3 times, most recently from 96e9836 to f55541e Compare August 24, 2023 16:49
@jordanbreen28 jordanbreen28 force-pushed the maint-update_puppetize_workflow branch 2 times, most recently from a14ff82 to a52adb8 Compare August 24, 2023 16:57
@jordanbreen28 jordanbreen28 force-pushed the maint-update_puppetize_workflow branch from a52adb8 to 0610aa0 Compare August 24, 2023 16:58
@jordanbreen28 jordanbreen28 marked this pull request as ready for review August 24, 2023 17:05
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner August 24, 2023 17:05
@jordanbreen28
Copy link
Author

Can be seen working here

@jordanbreen28 jordanbreen28 added bugfix and removed maintenance non-user-visible changes improving the infrastructure labels Aug 25, 2023
Import-Module -Name PSDesiredStateConfiguration -Force
Import-Module -Name Puppet.Dsc -Force
Import-Module -Name ./src/Puppet.Dsc -Force

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing... should we revert this back to not use the local version of the module?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to wait until its released to change it back incase we need to release any dsc modules

@GSPatton GSPatton merged commit 823a12c into main Aug 25, 2023
4 checks passed
@GSPatton GSPatton deleted the maint-update_puppetize_workflow branch August 25, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants