Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(REVERT) - Revert forcing of ensurable property on resources #283

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

jordanbreen28
Copy link

@jordanbreen28 jordanbreen28 commented Feb 7, 2024

Summary

This reverts commit 35a8f69.
As the ensurable property cannot be read on the target system, it would continuously report corrective changes on every puppet run when using the default Puppet::Property check.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 added the bug Something isn't working label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8f39e7d) 19.34% compared to head (96b2c18) 15.32%.

❗ Current head 96b2c18 differs from pull request most recent head d0b6ce2. Consider uploading reports for the commit d0b6ce2 to get more accurate results

Files Patch % Lines
...sc/internal/functions/Get-TypeParameterContent.ps1 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   19.34%   15.32%   -4.03%     
==========================================
  Files          47       47              
  Lines         884      868      -16     
==========================================
- Hits          171      133      -38     
- Misses        713      735      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review February 7, 2024 15:29
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner February 7, 2024 15:48
@jordanbreen28 jordanbreen28 force-pushed the revert_forced_ensurable_prop branch 7 times, most recently from 913ed69 to 49d8d9b Compare February 8, 2024 15:08
@jordanbreen28 jordanbreen28 force-pushed the revert_forced_ensurable_prop branch 7 times, most recently from febead6 to d0b6ce2 Compare February 8, 2024 16:17
@jordanbreen28 jordanbreen28 reopened this Feb 9, 2024
Copy link

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gavindidrichsen gavindidrichsen merged commit 655d088 into main Feb 9, 2024
28 of 29 checks passed
@gavindidrichsen gavindidrichsen deleted the revert_forced_ensurable_prop branch February 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants