(GH-71) Fix type def of props with optional nested cim instances #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit nested CIM instances would get an incorrect Puppet type definition, where optional types would not be prefaced as such. This commit updates the section of Get-DscResourceParameterInfoByCimClass which handles the Puppetization of the data type for nested CIM instances, adding a final check to validate whether or not the property is actually mandatory. This ensures that the types are correctly defined and can be passed as expected in a manifest.
jpogran
approved these changes
Nov 6, 2020
michaeltlombardi
deleted the
gh-71/main/fix-optional-nested-cim-instances
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit nested CIM instances would get an incorrect Puppet type definition, where optional types would not be prefaced as such.
This commit updates the section of
Get-DscResourceParameterInfoByCimClasswhich handles the Puppetization of the data type for nested CIM instances, adding a final check to validate whether or not the property is actually mandatory. This ensures that the types are correctly defined and can be passed as expected in a manifest.