Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) - Fix broken conditional on windows #87

Merged
merged 1 commit into from
May 2, 2024

Conversation

jordanbreen28
Copy link
Contributor

Summary

Removes conditional that does not work on windows. Opts for the github actions ternary syntax instead to avoid this happening,

Additional Context

Supporting docs
https://docs.github.com/en/actions/learn-github-actions/expressions#example
actions/runner#409 (comment)

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 force-pushed the maint-update_checkout_ref_gem_ci branch from 1ceb8d4 to 2e3a3fb Compare May 2, 2024 08:24
@jordanbreen28 jordanbreen28 marked this pull request as ready for review May 2, 2024 08:26
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner May 2, 2024 08:26
@david22swan david22swan merged commit 2a8f96d into main May 2, 2024
2 checks passed
@david22swan david22swan deleted the maint-update_checkout_ref_gem_ci branch May 2, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants