Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

run_user and run_group for device_manager::devices #76

Merged
merged 1 commit into from
Aug 10, 2020
Merged

run_user and run_group for device_manager::devices #76

merged 1 commit into from
Aug 10, 2020

Conversation

bFekete
Copy link
Contributor

@bFekete bFekete commented Jul 27, 2020

Allows users to customize run_user and run_group on device_manager to fix #65

@puppet-community-rangefinder
Copy link

device_manager::devices is a class

that may have no external impact to Forge modules.

This module is declared in 4 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   63.63%   63.63%           
=======================================
  Files           1        1           
  Lines          11       11           
=======================================
  Hits            7        7           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9939f2...2895435. Read the comment docs.

@david22swan david22swan changed the base branch from master to main August 6, 2020 11:09
@david22swan
Copy link
Member

@bFekete
Making a quick change to point this PR towards the newly defined default main branch as part of our work to remove inappropriate terminology. Apologies if this is inconvenient in any way.

Copy link
Contributor

@tkishel tkishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sanfrancrisko sanfrancrisko added enhancement bugfix Something isn't working and removed enhancement labels Aug 10, 2020
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bFekete !

@sanfrancrisko sanfrancrisko merged commit 1b4fbc2 into puppetlabs:main Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User and group puppet doesn't exists on CentOS8
5 participants